Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative filepath handling #114

Merged
merged 8 commits into from
Feb 6, 2025
Merged

relative filepath handling #114

merged 8 commits into from
Feb 6, 2025

Conversation

cefect
Copy link
Collaborator

@cefect cefect commented Jan 25, 2025

Continuation of fix for issue #104

implemented relative pathing for all unit tests. All tests are passing. The following is still needed:

  • Go through and check that wherever a build tool writes a filepath to the control file, the absolute_fp flag is respected (e.g., here).
  • extend test_tutorial_02.test_tutorial_02a() to include `absolute_fp. Should look something like:
@pytest.mark.parametrize('absolute_fp',[True, False])

Note that the absolute_fp attribute on the BuildDialog is properly setting its state based on the UI radio button, and this variable is also being collected with inherit_fieldNames (then presumably being passed to the worker inits as **kwargs). See here for example.

@cefect
Copy link
Collaborator Author

cefect commented Feb 6, 2025

merged in content from PR #111 . all the current tests pass (just need to add the tests described above)

@cefect cefect merged commit 9e6daf0 into dev Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants